Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename mixxx.{cpp,h} to mixxxmainwindow.{cpp,h} #4072

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

Holzhaus
Copy link
Member

@Holzhaus Holzhaus commented Jul 7, 2021

The file should have the same name as the class. I was confused by this more than once.

Copy link
Contributor

@Be-ing Be-ing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has confused me before as well. Waiting for CI.

Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uklotzde uklotzde merged commit 4aba92d into mixxxdj:main Jul 7, 2021
@JoergAtGithub
Copy link
Member

I just tried to build Main on windows and get:

1> [CMake] -- Configuring done
1> [CMake] CMake Error at buildenv/mixxx-deps-2.3-x64-windows-049b5ad/scripts/buildsystems/vcpkg.cmake:702 (_add_library):
1> [CMake]   Cannot find source file:
1> [CMake] 
1> [CMake]     src/mixxx.cpp
1> [CMake] 
1> [CMake]   Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .h .hh .h++
1> [CMake]   .hm .hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .ispc
1> [CMake] Call Stack (most recent call first):
1> [CMake]   CMakeLists.txt:366 (add_library)
1> [CMake] -- Generating done
1> [CMake] CMake Generate step failed.  Build files cannot be regenerated correct
```ly.

@Holzhaus
Copy link
Member Author

Holzhaus commented Jul 8, 2021

Please clean your build dir. I suppose there are leftover files from a previous build.

@JoergAtGithub
Copy link
Member

Solved it! It was some weird cleanup issue.

napaalm pushed a commit to napaalm/mixxx that referenced this pull request Mar 24, 2023
Rename mixxx.{cpp,h} to mixxxmainwindow.{cpp,h}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants