Traktor S3: Disable scratch when switching decks to prevent locked scratch issue #4073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I have retargeted this PR to the 2.3 branch. Please rebase it. |
evasadakkanalesso
force-pushed
the
fix_traktor_s3_scratching_lock
branch
from
de08636
to
a3f0009
Compare
|
Hi @Be-ing , It's done. 👍 |
|
Thank you. @ywwg wrote the mapping, so I'll leave it to him to review and test these changes. |
Holzhaus
changed the title
Hello everyone, Just realised the code above did not work. It worked for me because I use a modified version of this script. Thanks
ywwg
requested changes
Jul 23, 2021
Hi @ywwg, I have made the code change and tested on my machine and it seems to be working fine. Thank you 👍
ywwg
approved these changes
Jul 26, 2021
ywwg
approved these changes
Jul 26, 2021
|
@evasadakkanalesso As a first-time contributor we have to ask you to sign our contributor agreement: https://docs.google.com/forms/d/e/1FAIpQLScC9QG327sjLL0eWftmfGUasxFFLxg6LCXJ2xHDYRzFIRqyiw/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ @ywwg Please check before merging PRs. |
|
ah, yes, sorry. |
|
@evasadakkanalesso Hi, please let us know when you've signed the agreement -- otherwise we'll have to roll back this change because we need every contribution logged. |
|
Hi Owen,
I have done it a few days. I thought you'd get a message or something.
Thanks
…On Thu, Jul 29, 2021 at 2:07 PM Owen Williams ***@***.***> wrote:
@evasadakkanalesso <https://github.com/evasadakkanalesso> Hi, please let
us know when you've signed the agreement -- otherwise we'll have to roll
back this change because we need every contribution logged.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4073 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUW7MCFZJD3PIKNCZYPW32TT2FHA3ANCNFSM477QXO6Q>
.
|
|
Thanks! |
|
no problem thank you!
…On Fri, Jul 30, 2021 at 3:13 PM Owen Williams ***@***.***> wrote:
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4073 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUW7MCA5HVUO6UOSPB7F6QDT2KXO5ANCNFSM477QXO6Q>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I have been using the Traktor S3 controller mappings and have come across this sneaky bug. Steps to reproduce below:
This happens due to
TraktorS3.Deck.prototype.checkJogInertiafunction usingthis.activeChannelwhich is now different than the previous active channel. Traktor DJ Pro works the same way as in if you perform a spin in any direction and swap decks it interrupts the current spinning deck.Thanks Mixxx Dev for building such an amazing software!!!!
Thanks,
Eva