Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for test coverage information #4084

Merged
merged 3 commits into from
Jul 10, 2021
Merged

Conversation

Holzhaus
Copy link
Member

@Holzhaus Holzhaus commented Jul 8, 2021

Add support for determining test coverage and adds support for coveralls.io.

I ran this on my own fork, here's the result: https://coveralls.io/builds/41212778

Resolves #3149.

@Holzhaus Holzhaus requested a review from uklotzde July 8, 2021 12:20
@github-actions github-actions bot added the build label Jul 8, 2021
@Holzhaus Holzhaus changed the title Coverage Add support for test coverage information Jul 8, 2021
@Holzhaus
Copy link
Member Author

Holzhaus commented Jul 8, 2021

Sorry for the force-push, I just fixed a typo in a comment. Btw, you can see the diff of a force-push by clicking the "force-pushed" link: https://github.com/mixxxdj/mixxx/compare/5ef3219c63fe7e34f965c13987dd0dee26911329..49c8684481769aa498416ce84d42f72edcefd9d9

@Holzhaus
Copy link
Member Author

Holzhaus commented Jul 9, 2021

Merge?

@uklotzde
Copy link
Contributor

Yes. We don't even need to discuss about a minimum of 2 or more reviewers if no one volunteers.

@uklotzde uklotzde merged commit 9de885c into mixxxdj:main Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants