Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add [[nodiscard]] to lockMutex() #4097

Merged
merged 1 commit into from
Jul 10, 2021
Merged

Add [[nodiscard]] to lockMutex() #4097

merged 1 commit into from
Jul 10, 2021

Conversation

uklotzde
Copy link
Contributor

It is essential to capture the return value. Otherwise the mutex would be unlocked immediately.

@uklotzde
Add [[nodiscard]] to lockMutex()
f9d596b 
It is essential to capture the return value. Otherwise the mutex
would be unlocked immediately.
@Holzhaus
Copy link
Member

Thank you, very good addition. Waiting for CI.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1018348909

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 28.632%
Files with Coverage Reduction New Missed Lines %
src/engine/readaheadmanager.cpp 2 88.79%
Totals Coverage Status
Change from base Build 1018174960: -0.001%
Covered Lines: 20085
Relevant Lines: 70150
💛 - Coveralls

@Be-ing Be-ing merged commit c7d5334 into mixxxdj:main Jul 10, 2021
@uklotzde uklotzde deleted the qtmutex branch July 23, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Holzhaus Holzhaus Holzhaus approved these changes

Assignees
No one assigned
Labels
code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@uklotzde @Holzhaus @coveralls @Be-ing