Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ControlProxy cleanup #4106

Merged
merged 2 commits into from
Jul 22, 2021
Merged

ControlProxy cleanup #4106

merged 2 commits into from
Jul 22, 2021

Conversation

Holzhaus
Copy link
Member

No description provided.

@github-actions github-actions bot added the ui label Jul 15, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1033856848

  • 1 of 14 (7.14%) changed or added relevant lines in 2 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 28.629%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/engine/sidechain/enginerecord.cpp 0 3 0.0%
src/controllers/scripting/legacy/controllerscriptinterfacelegacy.cpp 1 11 9.09%
Files with Coverage Reduction New Missed Lines %
src/engine/enginevumeter.cpp 1 90.24%
src/engine/cachingreader/cachingreader.cpp 9 71.38%
Totals Coverage Status
Change from base Build 1033452289: -0.01%
Covered Lines: 20089
Relevant Lines: 70170
💛 - Coveralls

@Holzhaus
Copy link
Member Author

Any comments?

daschuer
daschuer approved these changes Jul 22, 2021
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@daschuer daschuer merged commit ebe8023 into mixxxdj:main Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
code quality ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Holzhaus @coveralls @daschuer