Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if HAVE_XSCREENSAVER_SUSPEND is defined befor using the value #4117

Merged
merged 1 commit into from
Jul 18, 2021
Merged

Check if HAVE_XSCREENSAVER_SUSPEND is defined befor using the value #4117

merged 1 commit into from
Jul 18, 2021

Conversation

daschuer
Copy link
Member

This fixes the following warning when building with MacOs:

2021-07-18T18:01:48.7733180Z ##[warning]/Users/runner/work/mixxx/mixxx/src/util/screensaver.cpp:33:28: warning: 'HAVE_XSCREENSAVER_SUSPEND' is not defined, evaluates to 0 [-Wundef]
2021-07-18T18:01:48.7791160Z #if defined(Q_OS_LINUX) || HAVE_XSCREENSAVER_SUSPEND

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1043244117

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.004%) to 28.641%
Files with Coverage Reduction New Missed Lines %
src/engine/cachingreader/cachingreader.cpp 1 74.64%
src/engine/cachingreader/cachingreaderworker.cpp 2 63.48%
Totals Coverage Status
Change from base Build 1042849443: -0.004%
Covered Lines: 20097
Relevant Lines: 70168
💛 - Coveralls

Holzhaus
Holzhaus approved these changes Jul 18, 2021
View reviewed changes
Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@Holzhaus Holzhaus merged commit eb76915 into mixxxdj:main Jul 18, 2021
@daschuer daschuer deleted the macos_screensaver_warning branch August 1, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Holzhaus Holzhaus Holzhaus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daschuer @coveralls @Holzhaus