Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPSCQueue: include BSD in hack around LLVM bug #4123

Merged
merged 1 commit into from
Jul 19, 2021
Merged

SPSCQueue: include BSD in hack around LLVM bug #4123

merged 1 commit into from
Jul 19, 2021

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Jul 19, 2021

No description provided.

daschuer
daschuer approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you

@Be-ing
Copy link
Contributor Author

Be-ing commented Jul 19, 2021

Merge?

@uklotzde uklotzde merged commit f48c276 into mixxxdj:2.3 Jul 19, 2021
@Be-ing Be-ing deleted the spscq_apple_hack_bsd branch July 19, 2021 23:07
@Holzhaus
Copy link
Member

Can you please open a PR for upstream and then mention the PR in a source code comment? Custom patches in the lib dir may be lost next time we update it.

@Be-ing
Copy link
Contributor Author

Be-ing commented Jul 20, 2021

We have. Upstream rejected it already because the bug isn't in the library, it's in LLVM. rigtorp/SPSCQueue#22

@Be-ing Be-ing mentioned this pull request Jul 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uklotzde uklotzde uklotzde approved these changes

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Be-ing @Holzhaus @uklotzde @daschuer