Preferences > Key: restore custom notation #4136
Conversation
There was a problem hiding this comment.
I don't fully understand the code changes to be honest, but I was able to confirm that the issue exists in main and 2.3 and is fixed by this PR.
Do yo want to include a changelog entry? I don't know our current policy on what to include in the changelog when.
| return; | ||
| } | ||
|
|
||
| void DlgPrefKey::setNotation(KeyUtils::KeyNotation notation) { |
There was a problem hiding this comment.
The whole class and especially these methods are not so great. But at least the handling is consistent now.
| for (auto it = m_keyLineEdits.constBegin(); | ||
| it != m_keyLineEdits.constEnd(); ++it) { | ||
| it.value()->setEnabled(true); | ||
| it.value()->setText(KeyUtils::keyToString(it.key(), notation)); | ||
| // QLineEdits are only enabled for Custon notation. |
ronso0
force-pushed
the
pref-key-restore-custom-notation
branch
2 times, most recently
from
a77f7fd
to
c270ba4
Compare
|
ready. |
| @@ -128,8 +128,11 @@ void DlgPrefKey::loadSettings() { | |||
| } | |||
| } | |||
|
|
|||
| setNotation(notation_type); | |||
| // Store notation map for later rećall... | |||
There was a problem hiding this comment.
Why all the accents? Maybe one of your keys got stuck ;)
There was a problem hiding this comment.
naa, my display now has cracks all over the left side. so usually it's 'why that accent? oh, it's just a crack..'
here it was the other way around : )
| KeyUtils::setNotation(notation); | ||
| // ... BEFORE invóking setNotation() which populates the QLineEdits from | ||
| // the map retreived from KeyUtils. |
ronso0
force-pushed
the
pref-key-restore-custom-notation
branch
from
c270ba4
to
761487c
Compare
|
pa-ping |
|
Thank you! LGTM |
reported in the forums
https://mixxx.discourse.group/t/custom-key-notation-not-saved-after-restart-in-2-3-0/
custom key notation was not restored correctly.
code is simpler now, too.
Proposed Changelog entry