Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SyncLock: update skin with new control object names #4149

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

ywwg
Copy link
Member

@ywwg ywwg commented Jul 26, 2021

No description provided.

@github-actions github-actions bot added the skins label Jul 26, 2021
@coveralls
Copy link

coveralls commented Jul 26, 2021

Pull Request Test Coverage Report for Build 1071289286

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 28.595%

Files with Coverage Reduction New Missed Lines %
src/engine/readaheadmanager.cpp 2 88.79%
src/engine/cachingreader/cachingreader.cpp 11 70.65%
Totals Coverage Status
Change from base Build 1070910911: -0.02%
Covered Lines: 20072
Relevant Lines: 70193

💛 - Coveralls

@ronso0
Copy link
Member

ronso0 commented Jul 26, 2021

please update LateNight/decks/rate_controls_compact.xml, too.

@ywwg
Copy link
Member Author

ywwg commented Jul 27, 2021

done

@ronso0
Copy link
Member

ronso0 commented Jul 27, 2021

Thanks, LGTM

btw, do we need Sync Leader as right-click action of Sync?
There's an explicit button now, and to make the Sync right-click discoverable discoverable we'd need to add a sync_enabled_leader tooltip ID (concatenated from existing sync_enabled and a new string).

@uklotzde uklotzde added this to the 2.4.0 milestone Jul 27, 2021
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@uklotzde uklotzde merged commit f4e4807 into mixxxdj:main Jul 27, 2021
@ronso0
Copy link
Member

ronso0 commented Jul 27, 2021

thanks @uklotzde I was pulled afk before I could hit merge...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants