Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix debug assertion for invalid main cue position #4153

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Fix debug assertion for invalid main cue position #4153

merged 1 commit into from
Jul 28, 2021

Conversation

uklotzde
Copy link
Contributor

Just occurred while listening to some old tracks.

@uklotzde uklotzde added this to the 2.4.0 milestone Jul 27, 2021
@uklotzde uklotzde requested a review from Holzhaus July 27, 2021 14:37
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1071561419

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 28.614%
Totals Coverage Status
Change from base Build 1070910911: 0.001%
Covered Lines: 20085
Relevant Lines: 70193
💛 - Coveralls

Holzhaus
Holzhaus approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@Holzhaus Holzhaus merged commit 1869621 into mixxxdj:main Jul 28, 2021
@uklotzde uklotzde deleted the maincueposition branch July 28, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Holzhaus Holzhaus Holzhaus approved these changes

Assignees
No one assigned
Labels
minor bug
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@uklotzde @coveralls @Holzhaus