Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: make FindPortAudio.cmake module export PortAudio::PortAudio #4166

Merged
merged 1 commit into from
Aug 1, 2021
Merged

CMake: make FindPortAudio.cmake module export PortAudio::PortAudio #4166

merged 1 commit into from
Aug 1, 2021

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Aug 1, 2021

to match targets exported by config files
PortAudio/portaudio#461
mixxxdj/vcpkg#20

@Be-ing Be-ing marked this pull request as draft August 1, 2021 01:22
@github-actions github-actions bot added the build label Aug 1, 2021
@Be-ing Be-ing marked this pull request as ready for review August 1, 2021 01:37
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1086260948

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 26.031%
Totals Coverage Status
Change from base Build 1086195532: 0.0%
Covered Lines: 20013
Relevant Lines: 76880
💛 - Coveralls

Holzhaus
Holzhaus approved these changes Aug 1, 2021
View reviewed changes
Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Holzhaus Holzhaus merged commit df504a6 into mixxxdj:main Aug 1, 2021
@Be-ing Be-ing deleted the portaudio_cmake_module branch August 1, 2021 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Holzhaus Holzhaus Holzhaus approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Be-ing @coveralls @Holzhaus