cmdlineargs: Error handling and translation #4170
Conversation
after the QApplication has processed the command line as well. This allows proper feedback when a unknown command line option is found and considers also the Qt internal command line arguments. As extra bounty the help output is now translated.
daschuer
force-pushed
the
command_line_fix_2
branch
from
993f365
to
e951cd5
Compare
|
I don't understand what "user feedback" means in this context. |
Pull Request Test Coverage Report for Build 1096626455
💛 - Coveralls |
|
Main silently starts if you have a typo in the command line option. Now it looks like this: |
|
The messages before the new line are slipping through before the logging is configured. |
src/util/cmdlineargs.cpp
Outdated
|
|
||
| void CmdlineArgs::parseForUserFeedback() { | ||
| DEBUG_ASSERT(QCoreApplication::instance()); | ||
| if (!m_hasUserFeedback) { |
There was a problem hiding this comment.
This condition seems to be wrong or I misunderstand the purpose/naming of the boolean.
There was a problem hiding this comment.
We need only execute the second run when the first run has produced user feedback, otherwise we can skip the second run. I am happy to rename the variable if you have a suggestion.
There was a problem hiding this comment.
m_requiresUserFeedback or m_needsUserFeedback? German: "erfordert"
There was a problem hiding this comment.
This may be read as if we require feedback from the user.
How about m_parseForUserFeedbackRequired?
src/util/cmdlineargs.cpp
Outdated
|
|
||
| bool CmdlineArgs::parse(const QStringList& arguments, bool forUserFeedback) { |
There was a problem hiding this comment.
Please add enum class ParseMode instead of using a boolean.
|
Done. |
|
Done |
Added a second parser path for user feedback after the QApplication has processed the command line as well.
This allows proper feedback when a unknown command line option is found and considers also the Qt internal command line arguments.
As extra bounty the help output is now translated.