Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MixxxMainWindow: Remove QApplication dependency #4173

Merged
merged 1 commit into from
Aug 4, 2021
Merged

MixxxMainWindow: Remove QApplication dependency #4173

merged 1 commit into from
Aug 4, 2021

Conversation

Holzhaus
Copy link
Member

@Holzhaus Holzhaus commented Aug 4, 2021

No description provided.

@Holzhaus Holzhaus added this to the 2.4.0 milestone Aug 4, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1097541576

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 26.012%
Files with Coverage Reduction New Missed Lines %
src/engine/readaheadmanager.cpp 2 88.79%
Totals Coverage Status
Change from base Build 1097150390: -0.003%
Covered Lines: 20007
Relevant Lines: 76914
💛 - Coveralls

uklotzde
uklotzde approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, no issues so far. LGTM

@uklotzde uklotzde merged commit 21f8839 into mixxxdj:main Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uklotzde uklotzde uklotzde approved these changes

@Be-ing Be-ing Be-ing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Holzhaus @coveralls @uklotzde @Be-ing