CMake: fix linking protobuf #4185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was broken by the refactoring for building with static libraries (c21aec2 mixxxdj#4163): mixxxdj#4163 (comment) https://mixxx.zulipchat.com/#narrow/stream/247620-development-help/topic/cmake.20fails.20with.20Could.20NOT.20find.20Protobuf
Be-ing
force-pushed
the
fix_protobuf_find
branch
from
cfb3757
to
d172f78
Compare
Be-ing
commented
Aug 6, 2021
| include(IsStaticLibrary) | ||
| if(TARGET protobuf::libprotobuf-lite) | ||
| target_link_libraries(mixxx-proto PRIVATE protobuf::libprotobuf-lite) | ||
| is_static_library(Protobuf_USE_STATIC_LIBS protobuf::libprotobuf-lite) |
There was a problem hiding this comment.
I'm doubt this is even needed. Protobuf_USE_STATIC_LIBS is a parameter for the Protobuf find module (https://cmake.org/cmake/help/latest/module/FindProtobuf.html) so I don't think it does anything after the find_package(Protobuf REQURIED).
There was a problem hiding this comment.
Oh yes. So lets remove it entirely. Do we have still a use case for setting it from Mixxx? If so, we can reintroduce it.
Pull Request Test Coverage Report for Build 1105940102
💛 - Coveralls |
|
Nice solution, to be honest I have not understand how it has ever worked. |
daschuer
approved these changes
Aug 6, 2021
|
Yes, BUILD_SHARED_LIBS is for setting how to link libraries being built by CMake, not for specifying whether dependencies are shared or static. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken by the refactoring for building with static
libraries (c21aec2 #4163):
#4163 (comment)
https://mixxx.zulipchat.com/#narrow/stream/247620-development-help/topic/cmake.20fails.20with.20Could.20NOT.20find.20Protobuf