Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix whitespace issues in all files of the repository #4203

Merged
merged 4 commits into from
Aug 19, 2021

Conversation

Holzhaus
Copy link
Member

I know we have a "no mass reformattings policy" but this only affects a few files with such issues and merge conflicts should be neglible. Then we don't have to disable these hooks globally on CI anymore.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1132429177

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 25.998%

Totals Coverage Status
Change from base Build 1127725238: 0.02%
Covered Lines: 20016
Relevant Lines: 76991

💛 - Coveralls

@Holzhaus
Copy link
Member Author

pre-commit fails due to eslint issues, but that is expected. I'm not going to fix all controller scripts without access to the hardware :D

Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally that all checks pass except clang-format and eslint as expected. Thank you! LGTM

@uklotzde uklotzde merged commit 52bcaf1 into mixxxdj:main Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants