Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library sidebar: also activate items on PageUp/Down events #4237

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Aug 21, 2021

Activate sidebar items also on PageUp / PageDown / Home / End events = update the table view
Affects keyboard and [Library],Scroll.. commands.

Previously those keys would move the sidebar selection as expected but the new item wasn't actually activated.
The table view didn't change, may even stay empty, which does cause panic in case you scroll up to Tracks ; )

@github-actions github-actions bot added the ui label Aug 21, 2021
@ronso0 ronso0 added the library label Aug 21, 2021
@ronso0 ronso0 added this to the 2.4.0 milestone Aug 21, 2021
@coveralls

This comment has been minimized.

@ronso0
Copy link
Member Author

ronso0 commented Aug 21, 2021

for the sake of completeness I'll also add Home/Pos1 and End

@ronso0
Copy link
Member Author

ronso0 commented Aug 21, 2021

the second commit is supposed to facilitate the navigation a bit:
Left now selects & activates the parent item. I'm used to it from some other app's tree view (Edit: Thunar and Thunderbird) and I find this very handy, e.g. when you're somewhere in the middle of a long crates list and want to jump to another root item (using PageUp/Down and Up/Down afterwards is cumbersome)

@ronso0 ronso0 changed the base branch from main to 2.3 August 29, 2021 18:35
@ronso0
Copy link
Member Author

ronso0 commented Aug 29, 2021

rebased on 2.3 since the PageUp issue is a bug actually.
Anyone around who cares to review this small fix?

@ronso0
Copy link
Member Author

ronso0 commented Aug 29, 2021

the second commit is supposed to facilitate the navigation a bit:
Left now selects & activates the parent item. I'm used to it from some other app's tree view (Edit: Thunar and Thunderbird) and I find this very handy, e.g. when you're somewhere in the middle of a long crates list and want to jump to another root item (using PageUp/Down and Up/Down afterwards is cumbersome)

I removed that commit. I does not yet work correctly for 2+ child levels. Once I figured that out I'll target it at main.
see #4253

So this simple fix is ready for merge @mixxxdj/developers

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants