-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library sidebar: also activate items on PageUp/Down events #4237
Conversation
This comment has been minimized.
This comment has been minimized.
for the sake of completeness I'll also add Home/Pos1 and End |
the second commit is supposed to facilitate the navigation a bit: |
rebased on 2.3 since the PageUp issue is a bug actually. |
I removed that commit. I does not yet work correctly for 2+ child levels. So this simple fix is ready for merge @mixxxdj/developers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you.
Activate sidebar items also on PageUp / PageDown / Home / End events = update the table view
Affects keyboard and
[Library],Scroll..
commands.Previously those keys would move the sidebar selection as expected but the new item wasn't actually activated.
The table view didn't change, may even stay empty, which does cause panic in case you scroll up to Tracks ; )