Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH Actions: fix Windows caching #4274

Merged
merged 2 commits into from
Sep 8, 2021
Merged

GH Actions: fix Windows caching #4274

merged 2 commits into from
Sep 8, 2021

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Sep 8, 2021

This was broken by #3809.

@Be-ing Be-ing requested a review from Holzhaus September 8, 2021 15:15
@Be-ing
Copy link
Contributor Author

Be-ing commented Sep 8, 2021

Windows build is back down to 15 minutes. Please merge promptly. I am tired of waiting 50 minutes for Windows CI jobs.

Holzhaus
Holzhaus approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@Holzhaus Holzhaus merged commit 35d2a9a into mixxxdj:2.3 Sep 8, 2021
@Be-ing
Copy link
Contributor Author

Be-ing commented Sep 8, 2021

Merge?

@Be-ing
Copy link
Contributor Author

Be-ing commented Sep 8, 2021

race condition :P

@Be-ing Be-ing deleted the windows_ci_cache branch September 8, 2021 17:12
@Be-ing
Copy link
Contributor Author

Be-ing commented Sep 8, 2021

Thanks for merging quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Holzhaus Holzhaus Holzhaus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Be-ing @Holzhaus