Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix preference option for re-analyzing beatgrids imported from other software #4288

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Fix preference option for re-analyzing beatgrids imported from other software #4288

merged 1 commit into from
Sep 16, 2021

Conversation

ninomp
Copy link
Contributor

@ninomp ninomp commented Sep 16, 2021 •
edited
Loading

I noticed a minor issue in the Beat Detection preferences, so I decided to fix it.

Steps to reproduce:

  1. Open Mixxx 2.3
  2. In the Beat Detection preferences, check the option "Re-analyze beatgrids imported from other DJ software"
  3. Restart Mixxx
  4. Notice that that option in the preferences is unchecked

@github-actions github-actions bot added the ui label Sep 16, 2021
daschuer
daschuer approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Good catch, thank you.

@daschuer daschuer merged commit 670bc63 into mixxxdj:2.3 Sep 16, 2021
@ninomp ninomp deleted the fix-beatgrid-reanalyze-imported branch September 16, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ninomp @daschuer