Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Reset main window title when all decks stop playing #4296

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Fix: Reset main window title when all decks stop playing #4296

merged 1 commit into from
Sep 17, 2021

Conversation

ninomp
Copy link
Contributor

@ninomp ninomp commented Sep 17, 2021

There is a minor UI issue affecting both 2.3 and main.

Steps to reproduce:

  1. Start playing a track in Mixxx
  2. Observe that main window title has updated to "Track title | Mixxx"
  3. Stop the track or let it finish playing
  4. Observe that main window title didn't reset to "Mixxx"

This behavior was introduced in 37c41e5.

@uklotzde
Copy link
Contributor

Good catch!

@uklotzde
Copy link
Contributor

No need to wait for CI. LGTM

@uklotzde uklotzde merged commit 086a791 into mixxxdj:2.3 Sep 17, 2021
@Be-ing
Copy link
Contributor

Be-ing commented Sep 17, 2021

We should always wait for CI, especially on the stable branch. It only takes 15-20 minutes.

@ninomp ninomp deleted the fix-playerinfo branch September 17, 2021 21:48
@uklotzde
Copy link
Contributor

Agreed. But this is not used in any tests and I checked all slots manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uklotzde uklotzde uklotzde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ninomp @uklotzde @Be-ing