Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove no longer valid assertion, fixing lp1943643 #4297

Merged
merged 1 commit into from
Sep 18, 2021
Merged

Remove no longer valid assertion, fixing lp1943643 #4297

merged 1 commit into from
Sep 18, 2021

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Sep 17, 2021 •
edited
Loading

uklotzde
uklotzde suggested changes Sep 18, 2021
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

src/library/trackset/baseplaylistfeature.cpp Show resolved Hide resolved
@daschuer
Copy link
Member Author 

critical [Main] DEBUG ASSERT: "row >= 0" in function TreeItem* TreeItem::child(int) const at /home/sperry/workspace/i18n/src/library/treeitem.cpp:52
 [Main] fatal /usr/include/x86_64-linux-gnu/qt5/QtCore/qlist.h:548 ASSERT failure in QList<T>::operator[]: "index out of range", file /usr/include/x86_64-linux-gnu/qt5/QtCore/qlist.h, line 548
--Type <RET> for more, q to quit, c to continue without paging--

Thread 1 "mixxx" received signal SIGABRT, Aborted.
__GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
50	../sysdeps/unix/sysv/linux/raise.c: Datei oder Verzeichnis nicht gefunden.
(gdb) bt
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1  0x00007ffff2dcf859 in __GI_abort () at abort.c:79
#2  0x00007ffff3435aad in qt_message_fatal
    (context=..., message=<synthetischer Zeiger>...)
    at global/qlogging.cpp:1907
#3  QMessageLogger::fatal(char const*, ...) const
    (this=this@entry=0x7fffffffbab0, msg=msg@entry=0x7ffff3714ee8 "ASSERT failure in %s: \"%s\", file %s, line %d") at global/qlogging.cpp:888
#4  0x00007ffff3434f46 in qt_assert_x(char const*, char const*, char const*, int)
    (where=where@entry=0x555556256d6a "QList<T>::operator[]", what=what@entry=0x555556252d52 "index out of range", file=file@entry=0x555556251ac8 "/usr/include/x86_64-linux-gnu/qt5/QtCore/qlist.h", line=line@entry=548)
    at ../../include/QtCore/../../src/corelib/global/qlogging.h:91
#5  0x00005555556b1890 in QList<TreeItem*>::operator[](int) const
    (i=-1, this=0x555558f7e540)
    at /usr/include/x86_64-linux-gnu/qt5/QtCore/qlist.h:547
#6  TreeItem::child(int) const (this=0x555558f7e530, row=row@entry=-1)
    at /home/sperry/workspace/i18n/src/library/treeitem.cpp:56
#7  0x0000555555acf2f4 in SidebarModel::index(int, int, QModelIndex const&) const
    (this=this@entry=0x555558df2730, row=row@entry=-1, column=column@entry=0, parent=...) at /home/sperry/workspace/i18n/src/library/sidebarmodel.cpp:134
--Type <RET> for more, q to quit, c to continue without paging--
#8  0x00007ffff35e331c in QAbstractItemModel::sibling(int, int, QModelIndex const&) const (this=0x555558df2730, row=-1, column=0, idx=...)
    at itemmodels/qabstractitemmodel.h:62
#9  0x0000555555ae9239 in QModelIndex::sibling(int, int) const
    (acolumn=<optimized out>, arow=-1, this=0x555558f26ca0)
    at /usr/include/x86_64-linux-gnu/qt5/QtCore/qabstractitemmodel.h:62
#10 BasePlaylistFeature::getSiblingPlaylistIdOf(QModelIndex&)
    (this=0x555558f26c50, start=...)
    at /home/sperry/workspace/i18n/src/library/trackset/baseplaylistfeature.cpp:365
#11 0x0000555555aed762 in BasePlaylistFeature::slotDeletePlaylist()
    (this=0x555558f26c50)
    at /home/sperry/workspace/i18n/src/library/trackset/baseplaylistfeature.cpp:401
#12 0x00007ffff3662458 in QtPrivate::QSlotObjectBase::call(QObject*, void**)
    (a=0x7fffffffbdc0, r=0x555558f26c50, this=0x555558f7c1a0)
    at ../../include/QtCore/../../src/corelib/kernel/qobjectdefs_impl.h:394
#13 QMetaObject::activate(QObject*, int, int, void**)
    (sender=0x555558f68e30, signalOffset=<optimized out>, local_signal_index=<optimized out>, argv=<optimized out>) at kernel/qobject.cpp:3784
#14 0x00007ffff66fc3e6 in QAction::triggered(bool)
    (this=this@entry=0x555558f68e30, _t1=<optimized out>)
    at .moc/moc_qaction.cpp:380
--Type <RET> for more, q to quit, c to continue without paging--
#15 0x00007ffff66feaa2 in QAction::activate(QAction::ActionEvent)
    (this=0x555558f68e30, event=<optimized out>) at kernel/qaction.cpp:1166
#16 0x00007ffff6884d12 in QMenuPrivate::activateCausedStack(QVector<QPointer<QWidget> > const&, QAction*, QAction::ActionEvent, bool)
    (this=this@entry=0x55555f679750, causedStack=..., action=action@entry=0x555558f68e30, action_e=action_e@entry=QAction::Trigger, self=self@entry=true)
    at widgets/qmenu.cpp:1355
#17 0x00007ffff688c4ae in QMenuPrivate::activateAction(QAction*, QAction::ActionEvent, bool)
    (this=this@entry=0x55555f679750, action=action@entry=0x555558f68e30, action_e=action_e@entry=QAction::Trigger, self=self@entry=true)
    at widgets/qmenu.cpp:1432
#18 0x00007ffff688d4d2 in QMenu::mouseReleaseEvent(QMouseEvent*)
    (this=0x7fffffffcd40, e=0x7fffffffc4a0) at widgets/qmenu.cpp:2912
#19 0x00007ffff67452b6 in QWidget::event(QEvent*)
    (this=this@entry=0x7fffffffcd40, event=event@entry=0x7fffffffc4a0)
    at kernel/qwidget.cpp:8981
#20 0x00007ffff688fadb in QMenu::event(QEvent*)
    (this=0x7fffffffcd40, e=0x7fffffffc4a0) at widgets/qmenu.cpp:3034
#21 0x00007ffff6702a66 in QApplicationPrivate::notify_helper(QObject*, QEvent*)
    (this=this@entry=0x5555566460d0, receiver=receiver@entry=0x7fffffffcd40, e=e@entry=0x7fffffffc4a0) at kernel/qapplication.cpp:3700
#22 0x00007ffff670c343 in QApplication::notify(QObject*, QEvent*)
--Type <RET> for more, q to quit, c to continue without paging--
    (this=<optimized out>, receiver=0x7fffffffcd40, e=0x7fffffffc4a0)
    at kernel/qapplication.cpp:3160



#23 0x00007ffff363693a in QCoreApplication::notifyInternal2(QObject*, QEvent*)
    (receiver=0x7fffffffcd40, event=0x7fffffffc4a0)
    at ../../include/QtCore/../../src/corelib/kernel/qobject.h:142



#24 0x00007ffff670b457 in QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer<QWidget>&, bool, bool)
    (receiver=0x7fffffffcd40, event=event@entry=0x7fffffffc4a0, alienWidget=0x0, nativeWidget=0x7fffffffcd40, buttonDown=buttonDown@entry=0x7ffff6c328d0 <qt_button_down>, lastMouseReceiver=..., spontaneous=true, onlyDispatchEnterLeave=false) at kernel/qapplication.cpp:2646




#25 0x00007ffff6761ce4 in QWidgetWindow::handleMouseEvent(QMouseEvent*)
    (this=0x55556518f7e0, event=0x7fffffffc920)
    at /usr/include/c++/9/bits/atomic_base.h:413

#26 0x00007ffff67641ec in QWidgetWindow::event(QEvent*)
    (event=0x7fffffffc920, this=0x55556518f7e0) at kernel/qwidgetwindow.cpp:289
#27 QWidgetWindow::event(QEvent*) (this=0x55556518f7e0, event=0x7fffffffc920)
    at kernel/qwidgetwindow.cpp:232


#28 0x00007ffff6702a66 in QApplicationPrivate::notify_helper(QObject*, QEvent*)
    (this=this@entry=0x5555566460d0, receiver=receiver@entry=0x55556518f7e0, e=e@entry=0x7fffffffc920) at kernel/qapplication.cpp:3700

#29 0x00007ffff670c0f0 in QApplication::notify(QObject*, QEvent*)
    (this=0x7fffffffde50, receiver=0x55556518f7e0, e=0x7fffffffc920)
--Type <RET> for more, q to quit, c to continue without paging--
    at kernel/qapplication.cpp:3446
#30 0x00007ffff363693a in QCoreApplication::notifyInternal2(QObject*, QEvent*)
    (receiver=0x55556518f7e0, event=0x7fffffffc920)
    at ../../include/QtCore/../../src/corelib/kernel/qobject.h:142
#31 0x00007ffff5f4d7d3 in QGuiApplicationPrivate::processMouseEvent(QWindowSystemInterfacePrivate::MouseEvent*) (e=e@entry=0x5555647993f0)
    at kernel/qguiapplication.cpp:2107
#32 0x00007ffff5f4f10b in QGuiApplicationPrivate::processWindowSystemEvent(QWindowSystemInterfacePrivate::WindowSystemEvent*) (e=e@entry=0x5555647993f0)
    at kernel/qguiapplication.cpp:1842
#33 0x00007ffff5f2935b in QWindowSystemInterface::sendWindowSystemEvents(QFlags<QEventLoop::ProcessEventsFlag>) (flags=flags@entry=...)
    at kernel/qwindowsysteminterface.cpp:1151
#34 0x00007fffea32f32e in xcbSourceDispatch(GSource*, GSourceFunc, gpointer)
    (source=<optimized out>) at qxcbeventdispatcher.cpp:105
#35 0x00007ffff226017d in g_main_context_dispatch ()
    at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#36 0x00007ffff2260400 in  () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#37 0x00007ffff22604a3 in g_main_context_iteration ()
    at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#38 0x00007ffff368e565 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) (this=0x555556701960, flags=...)
    at kernel/qeventdispatcher_glib.cpp:422
--Type <RET> for more, q to quit, c to continue without paging--
#39 0x00007ffff36354db in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) (this=this@entry=0x7fffffffccc0, flags=..., flags@entry=...)
    at ../../include/QtCore/../../src/corelib/global/qflags.h:140
#40 0x00007ffff688a0b1 in QMenu::exec(QPoint const&, QAction*)
    (this=this@entry=0x7fffffffcd40, p=..., action=action@entry=0x0)
    at ../../include/QtCore/../../src/corelib/global/qflags.h:120
#41 0x0000555555b11c88 in SetlogFeature::onRightClickChild(QPoint const&, QModelIndex const&) (this=0x555558f26c50, globalPos=..., index=...)
    at /home/sperry/workspace/i18n/src/library/trackset/setlogfeature.cpp:143
#42 0x00007ffff3662458 in QtPrivate::QSlotObjectBase::call(QObject*, void**)
    (a=0x7fffffffced0, r=0x555558df2730, this=0x55556052e850)
    at ../../include/QtCore/../../src/corelib/kernel/qobjectdefs_impl.h:394
#43 QMetaObject::activate(QObject*, int, int, void**)
    (sender=0x55556051fa00, signalOffset=<optimized out>, local_signal_index=<optimized out>, argv=<optimized out>) at kernel/qobject.cpp:3784
#44 0x0000555555cb28b5 in WLibrarySidebar::rightClicked(QPoint const&, QModelIndex const&) (_t2=..., _t1=..., this=0x55556051fa00)
    at /home/sperry/workspace/i18n/build/Debug/mixxx-lib_autogen/include/moc_wlibrarysidebar.cpp:156
#45 WLibrarySidebar::contextMenuEvent(QContextMenuEvent*)
    (this=0x55556051fa00, event=0x7fffffffd520)
    at /home/sperry/workspace/i18n/src/widget/wlibrarysidebar.cpp:36
#46 0x00007ffff67452b6 in QWidget::event(QEvent*)
--Type <RET> for more, q to quit, c to continue without paging--
    (this=this@entry=0x55556051fa00, event=event@entry=0x7fffffffd520)
    at kernel/qwidget.cpp:8981
#47 0x00007ffff67f2d52 in QFrame::event(QEvent*)
    (this=0x55556051fa00, e=0x7fffffffd520) at widgets/qframe.cpp:550
#48 0x00007ffff6977482 in QAbstractItemView::viewportEvent(QEvent*)
    (this=this@entry=0x55556051fa00, event=event@entry=0x7fffffffd520)
    at itemviews/qabstractitemview.cpp:1750
#49 0x00007ffff69e562f in QTreeView::viewportEvent(QEvent*)
    (this=0x55556051fa00, event=0x7fffffffd520) at itemviews/qtreeview.cpp:1318
#50 0x00007ffff363664b in QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*) (event=<optimized out>, receiver=<optimized out>)
    at kernel/qcoreapplication.cpp:1214
#51 QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*)
    (receiver=receiver@entry=0x5555605201a0, event=event@entry=0x7fffffffd520)
    at kernel/qcoreapplication.cpp:1203
#52 0x00007ffff6702a55 in QApplicationPrivate::notify_helper(QObject*, QEvent*)
    (this=this@entry=0x5555566460d0, receiver=receiver@entry=0x5555605201a0, e=e@entry=0x7fffffffd520) at kernel/qapplication.cpp:3694
#53 0x00007ffff670cb93 in QApplication::notify(QObject*, QEvent*)
    (this=<optimized out>, receiver=0x5555605201a0, e=0x7fffffffd520)
    at kernel/qapplication.cpp:3306
#54 0x00007ffff363693a in QCoreApplication::notifyInternal2(QObject*, QEvent*)
    (receiver=0x5555605201a0, event=0x7fffffffd520)
--Type <RET> for more, q to quit, c to continue without paging--
    at ../../include/QtCore/../../src/corelib/kernel/qobject.h:142
#55 0x00007ffff676194a in QWidgetWindow::handleMouseEvent(QMouseEvent*)
    (this=0x555556a37ea0, event=0x7fffffffd9e0) at kernel/qwidgetwindow.cpp:678
#56 0x00007ffff67641ec in QWidgetWindow::event(QEvent*)
    (event=0x7fffffffd9e0, this=0x555556a37ea0) at kernel/qwidgetwindow.cpp:289
#57 QWidgetWindow::event(QEvent*) (this=0x555556a37ea0, event=0x7fffffffd9e0)
    at kernel/qwidgetwindow.cpp:232
#58 0x00007ffff6702a66 in QApplicationPrivate::notify_helper(QObject*, QEvent*)
    (this=this@entry=0x5555566460d0, receiver=receiver@entry=0x555556a37ea0, e=e@entry=0x7fffffffd9e0) at kernel/qapplication.cpp:3700
#59 0x00007ffff670c0f0 in QApplication::notify(QObject*, QEvent*)
    (this=0x7fffffffde50, receiver=0x555556a37ea0, e=0x7fffffffd9e0)
    at kernel/qapplication.cpp:3446
#60 0x00007ffff363693a in QCoreApplication::notifyInternal2(QObject*, QEvent*)
    (receiver=0x555556a37ea0, event=0x7fffffffd9e0)
    at ../../include/QtCore/../../src/corelib/kernel/qobject.h:142
#61 0x00007ffff5f4d7d3 in QGuiApplicationPrivate::processMouseEvent(QWindowSystemInterfacePrivate::MouseEvent*) (e=e@entry=0x55555e2e3e40)
    at kernel/qguiapplication.cpp:2107
#62 0x00007ffff5f4f10b in QGuiApplicationPrivate::processWindowSystemEvent(QWindowSystemInterfacePrivate::WindowSystemEvent*) (e=e@entry=0x55555e2e3e40)
    at kernel/qguiapplication.cpp:1842
#63 0x00007ffff5f2935b in QWindowSystemInterface::sendWindowSystemEvents(QFlags<--Type <RET> for more, q to quit, c to continue without paging--
QEventLoop::ProcessEventsFlag>) (flags=flags@entry=...)
    at kernel/qwindowsysteminterface.cpp:1151
#64 0x00007fffea32f32e in xcbSourceDispatch(GSource*, GSourceFunc, gpointer)
    (source=<optimized out>) at qxcbeventdispatcher.cpp:105
#65 0x00007ffff226017d in g_main_context_dispatch ()
    at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#66 0x00007ffff2260400 in  () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#67 0x00007ffff22604a3 in g_main_context_iteration ()
    at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#68 0x00007ffff368e565 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) (this=0x555556701960, flags=...)
    at kernel/qeventdispatcher_glib.cpp:422
#69 0x00007ffff36354db in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) (this=this@entry=0x7fffffffdd80, flags=..., flags@entry=...)
    at ../../include/QtCore/../../src/corelib/global/qflags.h:140
#70 0x00007ffff363d246 in QCoreApplication::exec() ()
    at ../../include/QtCore/../../src/corelib/global/qflags.h:120
#71 0x0000555555735b5d in (anonymous namespace)::runMixxx
    (args=..., pApp=0x7fffffffde50)
    at /home/sperry/workspace/i18n/src/main.cpp:61
#72 main(int, char**) (argc=<optimized out>, argv=<optimized out>)
    at /home/sperry/workspace/i18n/src/main.cpp:185
(gdb)

uklotzde
uklotzde approved these changes Sep 18, 2021
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uklotzde uklotzde merged commit 7b849fb into mixxxdj:main Sep 18, 2021
@daschuer daschuer mentioned this pull request Sep 18, 2021
Merged
@daschuer daschuer deleted the lp1943643 branch September 26, 2021 17:40
@mixxxbot mixxxbot mentioned this pull request Aug 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uklotzde uklotzde uklotzde approved these changes

Assignees
No one assigned
Labels
library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daschuer @uklotzde