Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set continue-on-error: true for coveralls.io upload #4313

Merged
merged 1 commit into from
Sep 20, 2021
Merged

set continue-on-error: true for coveralls.io upload #4313

merged 1 commit into from
Sep 20, 2021

Conversation

daschuer
Copy link
Member

All other checks shall be continued if the coveralls.io upload fails because of server maintenance

@daschuer
set continue-on-error: true for coveralls.io upload
9e1af98 
All other checks shall be continued if the coveralls.io upload fails because of server maintenance
@Be-ing
Copy link
Contributor

Be-ing commented Sep 19, 2021

Please rebase to 2.3.

@Be-ing Be-ing changed the base branch from main to 2.3 September 19, 2021 22:33
@uklotzde
Copy link
Contributor

Ping

@daschuer daschuer changed the base branch from 2.3 to main September 20, 2021 08:01
@daschuer
Copy link
Member Author

coveralls is not enabled for 2.3

uklotzde
uklotzde approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uklotzde uklotzde merged commit ae58213 into mixxxdj:main Sep 20, 2021
@daschuer daschuer deleted the coveralls branch September 26, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uklotzde uklotzde uklotzde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daschuer @Be-ing @uklotzde