-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Componentsjs fix syncbutton #4329
Componentsjs fix syncbutton #4329
Conversation
Ouch it seems that I mixed this PR and the one on g4v controller. |
Please do an interactive rebase to separate the relevant commit from your other branch. |
There is no need to make a new PR. Do the rebase then force push this branch. |
OK. Thanks. I have a tendency to panic very fast with git. |
I did it but nothing has changed. |
Did you |
Yep :( |
8bedc66
to
4facec8
Compare
I think I manage :) |
But now I pushed an undesired change in CMakeLists.txt |
It looks like you picked the wrong commit. Don't panic, the commit you want is still there in your reflog. Run
|
4facec8
to
eb3ab38
Compare
Thanks! pre-commit issues are unrelated. |
Thanks to you, my friend. I will end learning git :) |
This PR fixes a small issue in the SyncButton component. Long press was nor working properly.