Fix race condition in ReplayGain test #4345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much. Can you link here the original report for later reference? |
|
Thanks for fixing this. It's not clear to me from looking at the diff what was causing the problem.
Yes, please put full URLs to bug reports in commit messages. |
ywwg
force-pushed
the
replaygain-test-fix
branch
2 times, most recently
from
955be72
to
b872f68
Compare
This test caused a race because it called slotLoadTrack instead of loadTrack, so it did not wait for the track to actually load. The test was quitting before the caching reader had a chance to finish setting up, so when the test was getting torn down there was a chance that the reader would try to access the objects while they were being destructed. Because the test infrastructure has its own destruction code, it's not clear if this crash could occur in regular code. Fixes https://bugs.launchpad.net/mixxx/+bug/1940589
ywwg
force-pushed
the
replaygain-test-fix
branch
from
b872f68
to
b60c00f
Compare
|
looks good |
|
That didn't work out: https://github.com/mixxxdj/mixxx/runs/3808718927 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test caused a race because it called slotLoadTrack instead of loadTrack, so it did not wait for the track to actually load. The test was quitting before the caching reader had a chance to finish setting up, so when the test was getting torn down there was a chance that the reader would try to access the objects while they were being destructed.
Because the test infrastructure has its own destruction code, it's not clear if this crash could occur in regular code.
Fixes https://bugs.launchpad.net/mixxx/+bug/1940589