Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blank duration in LateNight and Tango skins #4368

Merged
merged 3 commits into from
Oct 8, 2021

Conversation

ninomp
Copy link
Contributor

@ninomp ninomp commented Oct 8, 2021

This fixes a minor regression introduced with 640a59d.

Also, a warning is added to help prevent similar things from happening in the future.

Discussion: https://mixxx.zulipchat.com/#narrow/stream/109171-development/topic/Missing.20track.20duration.20in.20skins.20in.20main

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer daschuer merged commit 1d9c394 into mixxxdj:main Oct 8, 2021
@ninomp ninomp deleted the fix-blank-duration branch October 8, 2021 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants