Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update main cue position before seeking to it #4370

Merged
merged 2 commits into from
Oct 12, 2021
Merged

Update main cue position before seeking to it #4370

merged 2 commits into from
Oct 12, 2021

Conversation

ywwg
Copy link
Member

@ywwg ywwg commented Oct 9, 2021

@Holzhaus
Copy link
Member

Holzhaus commented Oct 9, 2021

Thanks. This bug only affects CDJ mode and the cue_cdj CO?

@ywwg
Copy link
Member Author

ywwg commented Oct 9, 2021

looking through the function, I believe this is the only mode affected. None of the others updated the cue position

Holzhaus
Holzhaus approved these changes Oct 10, 2021
View reviewed changes
Copy link
Member

@Holzhaus Holzhaus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you. Do you want to add a test?

@ywwg
Copy link
Member Author

ywwg commented Oct 10, 2021

oh I just found another instance of the same mistake, updating

@ywwg ywwg requested a review from Holzhaus October 10, 2021 21:48
@ninomp
Copy link
Contributor

ninomp commented Oct 12, 2021

I just tested this and it indeed solves the issue. Thanks

@Be-ing Be-ing merged commit c8c1855 into mixxxdj:main Oct 12, 2021
@ywwg ywwg mentioned this pull request Dec 5, 2021
Draft
@mixxxbot mixxxbot mentioned this pull request Aug 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Holzhaus Holzhaus Awaiting requested review from Holzhaus

Assignees
No one assigned
Labels
code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ywwg @Holzhaus @ninomp @Be-ing