use QString::mid instead of QString::midRef #4372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uklotzde
reviewed
Oct 10, 2021
Be-ing
force-pushed
the
qstring_midref
branch
from
4568f4a
to
490f58b
Compare
Be-ing
commented
Oct 12, 2021
src/dialog/dlgkeywheel.cpp
Outdated
| #if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0) | ||
| idView = idView.sliced(2, idView.size() - 2); | ||
| #else | ||
| idView = idView.mid(2); |
There was a problem hiding this comment.
I don't understand why this method is deprecated in Qt6. It is much more concise than the new sliced method in Qt6.
Be-ing
force-pushed
the
qstring_midref
branch
from
490f58b
to
0d63976
Compare
uklotzde
reviewed
Oct 12, 2021
Be-ing
force-pushed
the
qstring_midref
branch
from
0d63976
to
fe31d05
Compare
uklotzde
reviewed
Oct 12, 2021
src/dialog/dlgkeywheel.cpp
Outdated
| @@ -155,7 +155,14 @@ void DlgKeywheel::updateSvg() { | |||
|
|
|||
| if (text.isText()) { | |||
| QDomText textNode = text.toText(); | |||
| ChromaticKey key = static_cast<ChromaticKey>(id.midRef(2).toInt()); | |||
| #if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0) | |||
| QStringView idView(id); | |||
There was a problem hiding this comment.
What about the simplified expression I proposed? Didn't that work?
There was a problem hiding this comment.
Ah, I did not see the variant of QStringView::sliced that omits the second parameter.
Be-ing
force-pushed
the
qstring_midref
branch
from
fe31d05
to
c24af34
Compare
QString::midRef was removed in Qt6 https://doc.qt.io/qt-6/qtcore-changes-qt6.html#the-qstringview-class
Be-ing
force-pushed
the
qstring_midref
branch
from
c24af34
to
38d6394
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QString::midRef was removed in Qt 6.