Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BrowseFeature: remove unused #include <QDirModel> #4380

Merged
merged 1 commit into from
Oct 12, 2021
Merged

BrowseFeature: remove unused #include <QDirModel> #4380

merged 1 commit into from
Oct 12, 2021

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Oct 12, 2021

QDirModel has been removed in Qt6. The class is no longer used by
Mixxx anyway.

@Be-ing
BrowseFeature: remove unused #include <QDirModel>
9f1eed3 
QDirModel has been removed in Qt6. The class is no longer used by
Mixxx anyway.
@Be-ing Be-ing mentioned this pull request Oct 12, 2021
Open
4 tasks
uklotzde
uklotzde approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uklotzde uklotzde merged commit 099cb2d into mixxxdj:main Oct 12, 2021
daschuer
daschuer approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@Be-ing Be-ing deleted the remove_qdirmodel branch October 12, 2021 08:14
@daschuer daschuer mentioned this pull request Dec 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uklotzde uklotzde uklotzde approved these changes

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
library
Projects
Qt6
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Be-ing @uklotzde @daschuer