PlayerManager: Replace debug assertions with warnings #4427

uklotzde · 2021-10-15T12:14:04Z

Parsing of input data might fail at runtime and is not a programming error.

Lots of debug assertions on startup that need to be investigated separately.

src/mixer/playermanager.cpp

uklotzde · 2021-10-15T12:34:05Z

@be Please always run Mixxx with --debug-assert-break during development. Detecting and cleaning up these assertions afterwards is tedious.

uklotzde · 2021-10-15T12:50:44Z

Still doesn't work.

Parsing of input data might fail at runtime and is not a programming error.

Be-ing · 2021-10-15T13:03:18Z

waiting for CI

uklotzde · 2021-10-15T13:04:25Z

Ready. Please test!

uklotzde requested a review from Be-ing October 15, 2021 12:14

Holzhaus reviewed Oct 15, 2021

View reviewed changes

src/mixer/playermanager.cpp Outdated Show resolved Hide resolved

src/mixer/playermanager.cpp Outdated Show resolved Hide resolved

uklotzde marked this pull request as draft October 15, 2021 12:50

uklotzde added the regression label Oct 15, 2021

uklotzde added 2 commits October 15, 2021 14:58

PlayerManager: Replace debug assertions with warnings

db02acb

Parsing of input data might fail at runtime and is not a programming error.

PlayerManager: Fix regular expressions

609f7f6

Be-ing approved these changes Oct 15, 2021

View reviewed changes

uklotzde added the critical bug label Oct 15, 2021

uklotzde marked this pull request as ready for review October 15, 2021 13:04

Be-ing merged commit 01dc66a into mixxxdj:main Oct 15, 2021

uklotzde deleted the playermanager branch October 15, 2021 21:58

Provide feedback