Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FwdSqlQuery: Hide copy constructor #4429

Merged
merged 1 commit into from
Oct 15, 2021
Merged

FwdSqlQuery: Hide copy constructor #4429

merged 1 commit into from
Oct 15, 2021

Conversation

uklotzde
Copy link
Contributor

Another Qt6 prerequisite.

The design of these classes is brittle. Fortunately they are only used internally.

ninomp
ninomp reviewed Oct 15, 2021
View reviewed changes
src/util/db/fwdsqlquery.h Outdated Show resolved Hide resolved
Be-ing
Be-ing approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@Be-ing Be-ing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for CI

@Be-ing Be-ing merged commit df735e0 into mixxxdj:main Oct 15, 2021
@uklotzde uklotzde deleted the fwdsqlquery branch October 15, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninomp ninomp ninomp left review comments

@Be-ing Be-ing Be-ing approved these changes

Assignees
No one assigned
Labels
library
Projects
Qt6
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uklotzde @ninomp @Be-ing