Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseTrackTableModel: fix float conversion warning #4445

Merged
merged 1 commit into from
Oct 16, 2021

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Oct 16, 2021

[311/695] Building CXX object
CMakeFiles/mixxx-lib.dir/src/library/basetracktablemodel.cpp.o
../src/library/basetracktablemodel.cpp: In member function ‘virtual
QVariant BaseTrackTableModel::data(const QModelIndex&, int) const’:
../src/library/basetracktablemodel.cpp:423:27: warning: conversion from
‘double’ to ‘float’ may change value [-Wfloat-conversion]
  423 |         bgColor.setAlphaF(m_backgroundColorOpacity);
      |                           ^~~~~~~~~~~~~~~~~~~~~~~~

[311/695] Building CXX object
CMakeFiles/mixxx-lib.dir/src/library/basetracktablemodel.cpp.o
../src/library/basetracktablemodel.cpp: In member function ‘virtual
QVariant BaseTrackTableModel::data(const QModelIndex&, int) const’:
../src/library/basetracktablemodel.cpp:423:27: warning: conversion from
‘double’ to ‘float’ may change value [-Wfloat-conversion]
  423 |         bgColor.setAlphaF(m_backgroundColorOpacity);
      |                           ^~~~~~~~~~~~~~~~~~~~~~~~
Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Holzhaus Holzhaus merged commit dc3d9df into mixxxdj:main Oct 16, 2021
@Be-ing Be-ing deleted the basetracktablemodel_int_cast branch October 16, 2021 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants