Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qt6: Add a static cast to math_max #4454

Closed
wants to merge 1 commit into from
Closed

Qt6: Add a static cast to math_max #4454

wants to merge 1 commit into from

Conversation

daschuer
Copy link
Member

to make it work with the changed size type in Qt6

@Be-ing
Copy link
Contributor

Be-ing commented Oct 17, 2021 •
edited
Loading

Please don't create merge conflicts with #2618 before merging it.

@daschuer
Copy link
Member Author

I will take care of the conflict.

This is a trivial change and hopefully the last one that makes the main branch fail with Qt6.
This is required to a have a a succeeding CI in #4432

@Be-ing
Copy link
Contributor

Be-ing commented Oct 17, 2021

This is not really relevant to #4432. There are still tons of linker errors regardless of this.

@daschuer
Copy link
Member Author

This is at least a step forward and for #4428

@Be-ing Be-ing closed this Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daschuer @Be-ing