Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help text improvement for the Effect preferences. #4461

Merged
merged 5 commits into from
Dec 6, 2021
Merged

Help text improvement for the Effect preferences. #4461

merged 5 commits into from
Dec 6, 2021

Conversation

daschuer
Copy link
Member

This should be improved now .. hopefully.

@github-actions github-actions bot added the ui label Oct 19, 2021
@Be-ing
Copy link
Contributor

Be-ing commented Oct 21, 2021

I can't tell what changed in the second commit? Unfortunately the diffs Qt Designer creates are unreadable. I can't see a difference after building and running it.

@ronso0
Copy link
Member

ronso0 commented Oct 21, 2021

Unfortunately the diffs Qt Designer creates are unreadable.

yes, for example grid items are sometimes shuffled after minor edits, and they're saved in random order it appears. that's why I prefer to edit ui files manually.

@ronso0
Copy link
Member

ronso0 commented Oct 21, 2021

The texts are cropped so I can't tell how this is an improvement
2618
image

this PR
image

@Be-ing
Copy link
Contributor

Be-ing commented Oct 21, 2021

The first commit looks fine.

@daschuer daschuer mentioned this pull request Oct 21, 2021
Merged
@daschuer
Copy link
Member Author

I have set the line wrap flag, now it looks like this:
grafik

@ronso0
Copy link
Member

ronso0 commented Oct 21, 2021

Btw that screenshot shows that the Meta knob config should be moved above the tabs.

@daschuer @ronso0
Improve text even more.
efb4344 
Co-authored-by: ronso0 <ronso0@mixxx.org>
@daschuer
Copy link
Member Author

Done.

@daschuer daschuer mentioned this pull request Oct 21, 2021
Merged
17 tasks
@Be-ing
Copy link
Contributor

Be-ing commented Oct 21, 2021 •
edited
Loading

Btw that screenshot shows that the Meta knob config should be moved above the tabs.

As I have said already, I very much disagree. That is not important and should not be shown so prominently. Please remove the last commit.

@daschuer
Copy link
Member Author

Done

@Be-ing Be-ing deleted the branch mixxxdj:main October 26, 2021 01:49
@Be-ing Be-ing closed this Oct 26, 2021
@Be-ing Be-ing reopened this Oct 26, 2021
@Be-ing Be-ing changed the base branch from effects_refactoring to main October 26, 2021 02:00
@daschuer
Copy link
Member Author

Anything left to do here?

@Holzhaus Holzhaus merged commit 4e25c5f into mixxxdj:main Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronso0 ronso0 ronso0 left review comments

@Be-ing Be-ing Be-ing left review comments

@Holzhaus Holzhaus Holzhaus approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daschuer @Be-ing @ronso0 @Holzhaus