DlgPrefEffects: fix preset removed from list when canceling delete #4470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now there's no dialog anymore? Well...we could consider that bug fixed ;) |
|
Huh? |
I didn't test this, but looking at the diff I think nothing changed w.r.t. showing a dialog. Can you elaborate? |
|
Neither do I. What I did:
Rebasing onto #4467 doesn't fix it. |
ronso0
reviewed
Oct 22, 2021
| m_pChainPresetManager->deletePreset(selectedPresetName); | ||
| if (m_pChainPresetManager->deletePreset(selectedPresetName)) { | ||
| focusedChainStringList.removeAll(selectedPresetName); | ||
| } | ||
| } |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ronso0
reviewed
Oct 22, 2021
Comment on lines
268
to
292
| if (!unfocusedChainStringList.contains(selectedPresetName)) { | ||
| m_pChainPresetManager->deletePreset(selectedPresetName); | ||
| if (m_pChainPresetManager->deletePreset(selectedPresetName)) { | ||
| focusedChainStringList.removeAll(selectedPresetName); | ||
| } | ||
| } |
There was a problem hiding this comment.
else branch missing?
what happens when the preset is in both lists?
There was a problem hiding this comment.
added the missing else branch
|
LGTM, waiting for the green lights |
ronso0
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://bugs.launchpad.net/mixxx/+bug/1947922