Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qt6: Re-enable Waveform and WaveformFactory classes #4479

Merged
merged 1 commit into from
Oct 24, 2021
Merged

Qt6: Re-enable Waveform and WaveformFactory classes #4479

merged 1 commit into from
Oct 24, 2021

Conversation

uklotzde
Copy link
Contributor

We don't need to exclude these classes. Reduces the number of linker errors by ~40 lines.

@uklotzde uklotzde requested a review from Be-ing October 24, 2021 16:45
@github-actions github-actions bot added the build label Oct 24, 2021
Be-ing
Be-ing approved these changes Oct 24, 2021
View reviewed changes
Copy link
Contributor

@Be-ing Be-ing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These classes don't have any direct dependency on QGLWidget.

@Be-ing Be-ing merged commit 6e04d58 into mixxxdj:main Oct 24, 2021
@Be-ing
Copy link
Contributor

Be-ing commented Oct 24, 2021

No C++ changes, no need to wait for build-checks on this PR.

@uklotzde uklotzde deleted the qt6-waveform branch October 25, 2021 21:27
@daschuer daschuer mentioned this pull request Dec 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Be-ing Be-ing Be-ing approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uklotzde @Be-ing