Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce the Quick effect selectors in the EQ preferences #4485

Conversation

daschuer
Copy link
Member

We need that to merge the effects_refactoring branch without a regression until the Skin effect GUI is in place. https://bugs.launchpad.net/mixxx/+bug/1948537

This does not revert to the 2.4 state where single effects where selected, It selects the effect chain presets and is fully aligned with the upcoming chain preset selectors in the skins.

We need that to merge the effects_refactoring branch without a regression until the Skin effect GUI is in place. https://bugs.launchpad.net/mixxx/+bug/1948537
@github-actions github-actions bot added the ui label Oct 25, 2021
@daschuer daschuer mentioned this pull request Oct 25, 2021
17 tasks
@Be-ing
Copy link
Contributor

Be-ing commented Oct 26, 2021

I have already explicitly told you to not do this multiple times and explicitly told you to stop opening PRs for ideas which have already been rejected. This is counterproductive. If you want to help, then add the new widgets to the rest of the skins.

@Be-ing Be-ing closed this Oct 26, 2021
@daschuer
Copy link
Member Author

It is quite natural that we have open differences in our opinions. In the sense of a good team spirit, I expect an open minded discussion about theses topics and not just close this PR without giving any reasons. I also think that your firm voice is not appropriate in this discussion.

I have outlined the main reason of "making progress and keeping Mixxx usable" here and I have also outlined my ideas in general in the bug report: https://bugs.launchpad.net/mixxx/+bug/1948537
With this merge, we have chance to take all the pressure form #4467

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants