Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beats: Use "last marker" term instead of "end marker" #4510

Merged
merged 2 commits into from
Nov 11, 2021
Merged

Beats: Use "last marker" term instead of "end marker" #4510

merged 2 commits into from
Nov 11, 2021

Conversation

Holzhaus
Copy link
Member

@Holzhaus Holzhaus commented Nov 9, 2021

@Holzhaus Holzhaus added this to the 2.4.0 milestone Nov 9, 2021
@Holzhaus Holzhaus requested a review from ywwg November 9, 2021 23:07
ywwg
ywwg approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@ywwg ywwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this name change, it helps. I made just one note to add an explanatory comment.

src/track/beats.h Show resolved Hide resolved
@JoergAtGithub
Copy link
Member

I guess there is the word "one" missing in line 61?

@Holzhaus
Copy link
Member Author

I guess there is the word "one" missing in line 61?

Yup, Fixed.

@ywwg ywwg merged commit f981c8e into mixxxdj:main Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywwg ywwg ywwg approved these changes

Assignees
No one assigned
Labels
code quality
Projects
Beats Refactoring
Status: Done
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Holzhaus @JoergAtGithub @ywwg