Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controller logging categories #4522

Closed
wants to merge 7 commits into from
Closed

Controller logging categories #4522

wants to merge 7 commits into from

Commits on Nov 14, 2021

  1. Controller: make m_sDeviceName const 

    This will be required to use it in a QLoggingCategory which has a
deleted copy constructor.
    @Be-ing
    Be-ing committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    088e3a1 View commit details
    Browse the repository at this point in the history

  2. replace --controller-debug CLI argument with Qt logging categories 

    Logging is separated into several subcategores:
controller.CONTROLLERNAME: general messages
controller.CONTROLLERNAME.input: incoming data
controller.CONTROLLERNAME.output: outgoing data

CONTROLLERNAME is the lowercase device name with non-alphanumeric
characters removed.

This allows more fine tuned control of what messages are shown
in the console. This is required for the logging output to be
useful with controllers that continually send input such as the
Native Instruments Traktor Kontrol S4 Mk3 and Gemini GMX.
    @Be-ing
    Be-ing committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    5145f9d View commit details
    Browse the repository at this point in the history

  3. HSS1394/PortMidiController: remove superfluous QString formatting

    @Be-ing
    Be-ing committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    a073bff View commit details
    Browse the repository at this point in the history

  4. MidiOutputHandler: correct comment

    @Be-ing
    Be-ing committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    af04069 View commit details
    Browse the repository at this point in the history

  5. common-controller-scripts.js: use console.log for print 

    instead of engine.log. This sends script debugging output to a
separate Qt logging category (js) than logging from C++ code.
Unfortunately Qt does not (currently) provide an API to set the
logging category used by console.log, so if multiple controller
scripts are running, they will all use the same js logging
category.
    @Be-ing
    Be-ing committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    bb7d234 View commit details
    Browse the repository at this point in the history

  6. Hercules DJ Console 4 Mx: use console.log instead of engine.log 

    This was the only script directly using engine.log instead of
the print wrapper in common-controller-scripts.js.
    @Be-ing
    Be-ing committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    70a1028 View commit details
    Browse the repository at this point in the history

  7. remove ControllerDebug 

    It has been replaced by categorized logging.
    @Be-ing
    Be-ing committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    943beb6 View commit details
    Browse the repository at this point in the history