Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define CFBundleName in macOS bundle #4546

Merged
merged 1 commit into from
Nov 28, 2021
Merged

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Nov 28, 2021

CFBundleName declares the menu bar name as documented here and lets us display the name "Mixxx" with proper capitalization in the macOS menu bar:

Screen Shot 2021-11-28 at 14 18 58

Previously, it looked like this:

Screen Shot 2021-11-28 at 14 19 14

@Holzhaus
Copy link
Member

Thanks for looking into it. I cannot verify if it works, and according to the docs this should not be necessary because we already set CFBundleDisplayName:

The system may display it to users if CFBundleDisplayName isn't set.

However, if you tested it, I see no reason to not merge this.

@fwcd
Copy link
Member Author

fwcd commented Nov 28, 2021

I was a bit confused by the docs too, apparently they are mainly focused on iOS where the concept of a menu bar doesn't exist. In my tests and according to this stackoverflow post, it seems to be used for the menu bar indeed.

Can't hurt to declare it, however it may be, though. :)

@Holzhaus
Copy link
Member

Alright, then let's merge it! 👍

@Holzhaus Holzhaus merged commit 7763476 into mixxxdj:main Nov 28, 2021
@Holzhaus Holzhaus added changelog This PR should be included in the changelog packaging/installer labels Nov 28, 2021
@Holzhaus Holzhaus added this to the 2.4.0 milestone Nov 28, 2021
@fwcd fwcd deleted the cfbundlename branch November 28, 2021 18:39
@ronso0
Copy link
Member

ronso0 commented Nov 28, 2021

@fwcd I think even though this is a small change we need you sign the Mixxx contributor agreement.
Please comment here when done.

Thank you!

@fwcd
Copy link
Member Author

fwcd commented Nov 28, 2021

@ronso0 Done!

@fwcd fwcd added the macos label Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog This PR should be included in the changelog macos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants