-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QML: Add developer tools window #4568
Conversation
65b0022
to
c45eadb
Compare
lol I should have read this before my comment in #4567 ! |
I am building qt6 so I can review these -- code looks fine but I'd like to be able to see it for myself |
Oh, this PR is not finished yet. You can see the controls but changing them does not work atm. Also, Mixxx does not build with Qt6 yet. To test the QML UI, Qt5 suffices. I think current main requires at least Qt 5.12, but this PR needs Qt 5.15. |
Editing works now, but the values donz update yet. The QWidgets UI polls all controls using a timerEvent, but this does not work with QML and updating them via connections should be more performant anyway. |
okay, it's not pretty but it works now. Just build Mixxx as you normally would (using Qt 5.15), then run mixxx using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I figured out how to make it work finally. looks good!
96b9dd0
to
aa093d5
Compare
Alright, then feel free to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is broken. Seems like you forgot to include TextField.qml
and didn't register some types:
warning [Main] QQmlApplicationEngine failed to load component
warning [Main] file:///home/swiftb0y/Sourcerepositories/mixxx/res/qml/main.qml:92:21: Type DeveloperToolsWindow unavailable
warning [Main] file:///home/swiftb0y/Sourcerepositories/mixxx/res/qml/DeveloperToolsWindow.qml:20:9: Type Skin.TextField unavailable
warning [Main] file:///home/swiftb0y/Sourcerepositories/mixxx/res/qml/TextField.qml: No such file or directory
critical [Main] Failed to load QML file "res/qml/main.qml"
aa093d5
to
d40b4b1
Compare
thanks |
I am currently uncapable to review this properly.
since this is high-flux developer code I don't think it has to be perfect UI. we can iterate as needed but it sounds like this is needed to unblock QML work |
No description provided.