Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lp1955159: Prevent resetting of played history in database #4578

Merged
merged 1 commit into from
Dec 22, 2021
Merged

lp1955159: Prevent resetting of played history in database #4578

merged 1 commit into from
Dec 22, 2021

Conversation

uklotzde
Copy link
Contributor

Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, I leave it up to @ywwg to confirm that it actually fixes the bug.

@ywwg
Copy link
Member

ywwg commented Dec 22, 2021

I don't have a solid way to reproduce the bug yet. I think this code looks good and is ok to merge now, and then I can see if I can reproduce the issue later.

@ywwg ywwg merged commit 92960f4 into mixxxdj:main Dec 22, 2021
@uklotzde uklotzde deleted the lp1955159-trackdao-played-history branch December 22, 2021 20:55
@ronso0 ronso0 added this to the 2.4.0 milestone Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants