Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DlgTrackInfo: ensure Beats pointer before scaling beats #4587

Merged
merged 2 commits into from
Dec 28, 2021
Merged

DlgTrackInfo: ensure Beats pointer before scaling beats #4587

merged 2 commits into from
Dec 28, 2021

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Dec 28, 2021

prevent crash when scaling 0.0 BPM
https://bugs.launchpad.net/mixxx/+bug/1955853

@ronso0
Copy link
Member Author

ronso0 commented Dec 28, 2021 •
edited
Loading

oh, that was already fixed in main en passant?
nope #4409 only added a similiar way to handle scale button requests.

@ronso0
Copy link
Member Author

ronso0 commented Dec 28, 2021

In both 2.3 and main the track dialog lacks the test if (m_pBeatsClone) ..
And in both branches we could get rid of the Bpm slots if we connect the buttons like in WTrackmenu
https://github.com/mixxxdj/mixxx/blob/main/src/widget/wtrackmenu.cpp#L353-L370

uklotzde
uklotzde suggested changes Dec 28, 2021
View reviewed changes
src/library/dlgtrackinfo.h Outdated Show resolved Hide resolved
uklotzde
uklotzde approved these changes Dec 28, 2021
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@uklotzde uklotzde merged commit ee071a6 into mixxxdj:2.3 Dec 28, 2021
@ronso0 ronso0 deleted the bpm-crash-halve-double branch December 28, 2021 16:40
@ronso0
Copy link
Member Author

ronso0 commented Dec 28, 2021

I'll merge 2.3 to main now

@daschuer daschuer added the changelog This PR should be included in the changelog label Jan 7, 2022
@mixxxbot mixxxbot mentioned this pull request Aug 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swiftb0y Swiftb0y Swiftb0y left review comments

@uklotzde uklotzde uklotzde approved these changes

Assignees
No one assigned
Labels
changelog This PR should be included in the changelog critical bug library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ronso0 @uklotzde @Swiftb0y @daschuer