Deere: add QuickEffect selector #4590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good!
Yeah, thanks for daring to deal with that. I regret adding so much complexity to one skin. 🙈 |
|
Never mind, actually it's only the mixer (main VU column) and working around lp:1578111 which makes adjusting the mixer more complicated than necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With 4 decks the selector is quite small, but I don't really know how to fix that except expanding the entire mixer (which adds a lot of
whitegreyspace and results in Deere not being compatible anymore with 1024px screens. And I'm not very keen on investing more work in the complicated mixer layout)