Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LateNight: add effect chain menu button #4593

Merged
merged 1 commit into from
Jan 1, 2022

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Dec 30, 2021

image
image

@github-actions github-actions bot added the skins label Dec 30, 2021
Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you. I think it might be worth considering to use a selector like the quickeffect combobox in the mixer section, at least if we want to make it usable with a controller. But no need to block this IMHO.

@ronso0
Copy link
Member Author

ronso0 commented Jan 1, 2022

Hmm, this is easier said than done because it's not only a list but also contains submenus.
I think for controller access we should rather add a control to open/close the menu, then use [Library],MoveUp/Down/Vertical to navigate and [Library],GoToItem to select. This works well for the track menu already.

@Holzhaus
Copy link
Member

Holzhaus commented Jan 1, 2022

Yes, we could consider that. But it's not crucial for 2.4.0 IMHO. In any case, we can merge this now.

@Holzhaus Holzhaus merged commit e86f01f into mixxxdj:main Jan 1, 2022
@ronso0 ronso0 deleted the fxrfct-late-fx-menu branch January 1, 2022 23:06
@Be-ing
Copy link
Contributor

Be-ing commented Jan 2, 2022

controller access we should rather add a control to open/close the menu

The only feature from this menu I intended to be used from controllers is loading presets that already exist, which there already is a ControlObject for. I suppose you could add a CO to save a new preset... but then you have to move your hands from the controller to type the name in the dialog box anyway, so I don't think it would be worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants