Sync track metadata: Pass parameters explicitly #4605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Force pushed after renaming the type. This could be used not only for exporting metadata. |
Do not rely on side-effects when exporting track metadata. Passing all arguments explicitly improves testability.
|
Picked some more low hanging fruits in |
uklotzde
changed the title
|
If you want me to provide additional tests then please consider merging these prerequisites. |
|
(you may merge this yourself in case there are any other minor tweaks.) |
|
Merging now. Otherwise I would not able to write a regression for an upcoming PR. Splitting into smaller PRs was requested. But if I have to wait days before continuing this doesn't work for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another preliminary PR to improve testability, i.e. do not rely on side-effects when updating/importing and exporting track metadata.