CrateFeature: add popup to avoid accidental remove of Crate #4700
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have fixed the accidental remove issue for crates as well by adding a popup just like I did for the playlists.
I know making popups everywhere is not a proper solution for accidental removal issues because these popups are affecting usability a lot. There are better solutions for that like discussed on the other Pull request; redo/undo button, check-boxes that we can change on the Options>Preferences “Warn before deleting a playlist\crate” or a checkbox like “Don’t show this again”, etc.
After adding this popup for the playlists, a few people wanted it for crates too. Therefore I did it. I want to contribute more so any feedback will be good for me :)
In my opinion for now popups can be our problem solver, then later on better solution can be implemented.