Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Effect crasher fix #4707

Merged
merged 22 commits into from
Nov 3, 2022
Merged

Effect crasher fix #4707

merged 22 commits into from
Nov 3, 2022

Commits on Mar 16, 2022

  1. Added a TODO for a probably data race in effectprocessor.

    @daschuer
    daschuer committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    29fa03b View commit details
    Browse the repository at this point in the history

  2. Added a TODO for another probably data race in effectprocessor.

    @daschuer
    daschuer committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    36fbe82 View commit details
    Browse the repository at this point in the history

  3. Remove unused function EnginEffectChain::getChannelStatus()

    @daschuer
    daschuer committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    027ddee View commit details
    Browse the repository at this point in the history

  4. Avoid write access via reference

    @daschuer
    daschuer committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    fd60cf9 View commit details
    Browse the repository at this point in the history

  5. Add ChannelHandleMap::isEmpty()

    @daschuer
    daschuer committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    e379844 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2022

  1. Pass ChannelHandleAndGroup instead of just the group name to avoid ha… 

    …ndle lookup
    @daschuer
    daschuer committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    b019fa7 View commit details
    Browse the repository at this point in the history

  2. Move the skin warning before the assertion

    @daschuer
    daschuer committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    f5bb9a1 View commit details
    Browse the repository at this point in the history

  3. Enable the effects AFTER we have added effect slots

    @daschuer
    daschuer committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    5663ae2 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2022

  1. extend scope for a better readability

    @daschuer
    daschuer committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    895a7e8 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2022

  1. Introduce an updateActiveState() function to be able to clean up buff… 

    …ers after a channel has been disabled.
    @daschuer
    daschuer committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    2d2bb6c View commit details
    Browse the repository at this point in the history

  2. process one more buffer after eject

    @daschuer
    daschuer committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    dff90d2 View commit details
    Browse the repository at this point in the history

  3. Use the fadeout flag to fade down and initialize the effect buffers w… 

    …hen a stream is paused. Fixes lp1966607
    @daschuer
    daschuer committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    bf1af79 View commit details
    Browse the repository at this point in the history

  4. EffectProcessor: split out initalizeChannelHandle

    @daschuer
    daschuer committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    313d4ab View commit details
    Browse the repository at this point in the history

  5. Don't delete effect state object when chain is disabled. From the use… 

    …r perspective it is no difference between disabling an effect or a chain.
    @daschuer
    daschuer committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    c4b081a View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2022

  1. Use override keyword

    @daschuer
    daschuer committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    b4dc449 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2022

  1. Manage the lifetime of the effect state by a std::unique_ptr

    @daschuer
    daschuer committed Apr 3, 2022
    Configuration menu
    Copy the full SHA
    2250eaa View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2022

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring_3

    @daschuer
    daschuer committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    27dd095 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2022

  1. Added missing null check in CueControl::hintReader() 

    This is a regression since mixxxdj#4771
    @daschuer
    daschuer committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    cba84c1 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. re-enabble debug guard

    @daschuer
    daschuer committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    5d63ac3 View commit details
    Browse the repository at this point in the history

  2. Introduce kInitalSamplerRate to use before the SoundDevice is set up

    @daschuer
    daschuer committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    b504c61 View commit details
    Browse the repository at this point in the history

  3. Avoid confusing handle().handle() code

    @daschuer
    daschuer committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    3528e4c View commit details
    Browse the repository at this point in the history

  4. Added missing final keyword

    @daschuer
    daschuer committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    8d133e6 View commit details
    Browse the repository at this point in the history