Spinback fix #4708

ronso0 · 2022-03-29T21:30:19Z

Fixes a few spinback "regressions" noticed in #4705

fix infinite acceleration (never comes to halt currently)
spinback when interrupting softStart (was spinning forward)
allow spinback on stopped deck

The first two are fixed by a single - 7fed042 (after hours trying to understand the alpha-beta scratch filter).

Allowing spinback on stopped deck (IIRC that was working a few years back) was more work as it required cleaning up brake(), and I hope someone has motivation to review it so we can merge it to "stable" 2.3

remove debug output / use kLogger?

ronso0 · 2022-03-29T21:31:51Z

still draft because I'd like to keep the debug output 87c23c2 until review is finished.

ronso0 · 2022-03-30T10:48:48Z

Also: merging this to main requires manual editing since there are conflicts with renamed and moved files ( + clang-format, no actual behaviour or syntax changes in the functions I touched).
git diff upstream/2.3:src/controllers/controllerengine.cpp upstream/main:src/controllers/scripting/legacy/controllerscriptinterfacelegacy.cpp

Please ping me before merging so I can make sure I have time to merge to main !!

* allow spinback when deck is stopped * use -kBrakeRampToRate for spinback to avoid long, inaudible run out * don't allow brake to interrupt spinback * add stopScratchTimer() to remove redundant code

daschuer

Some more comments. I hope I will find time for a manual test soon.

src/controllers/controllerengine.cpp

ronso0 · 2022-03-30T22:29:42Z

Some more comments. I hope I will find time for a manual test soon.

I am testing with the GUI and a MIDI Through mapping. It uses callbacks of toggles on deck2 to init effects on deck1:
https://gist.github.com/ronso0/70bc239c14c1de491dbb87dc303a789f
Eject = init brake
Repeat = init spinback
Slip mode = init softstart

ronso0 · 2022-03-30T22:36:58Z

Thanks, I pushed th small fixes.

daschuer · 2022-04-03T19:50:18Z

I have tested it and I think it works like desired.
So I think it is ready to polish for merge.

I must admit hat I have never used the backspin effect before and I think it is implemented unnaturally.
My expectation was that it sound like pushing a vinyl backward with a sharp acceleration an a spin down phase afterwards. Something like demonstrated here: https://www.youtube.com/watch?v=dzEJoSkwvnI at 0:20
Is this a topic of this PR?

ronso0 · 2022-04-03T20:38:46Z

Exactly, that's how a backspin is supposed to sound like.
I am sure it was initially implemented like this (I simply doubt someone would implement it in such a weird way as it is now), so I suspect something broke since then, but I didn't figure out when with a quick git search.
Edit I missed "sharp acceleration". Yes, currently the backspin kicks in instantly, no accel. phase.

Actually I think some of the debug output is quite helpful, so I'll remove some of it and put the helpful part behind
#ifdef SCRATCH_DEBUG
Okay?

ronso0 · 2022-04-03T20:39:11Z

Thanks for testing btw, appreciated!

daschuer · 2022-04-04T05:21:09Z

Yes OK, thank you.

daschuer · 2022-04-04T05:23:22Z

I will file a bug for the implementation issue. Maybe we find a GSoC contributor taking care with @ywwg.

daschuer · 2022-04-04T05:32:47Z

https://bugs.launchpad.net/mixxx/+bug/1967715

ronso0 · 2022-04-05T22:40:29Z

Last commit disables the debug output in real-time code.
Ready for merge.

daschuer · 2022-04-06T06:42:12Z

src/controllers/controllerengine.cpp


    // Give the filter a data point:

    // If we're ramping to end scratching and the wheel hasn't been turned very
    // recently (spinback after lift-off,) feed fixed data
+    qDebug() << ".";


Her is a leftover

whoops, fixed.

damn, not fixed, didn't git add it proeprly :|
I pushed the fix to 2.3
045ce55

daschuer

Thank you. LGTM

ronso0 added 4 commits March 29, 2022 02:10

Spinback: fix infinite acceleration

7fed042

Brake, spinback, softStart: add debug output

87c23c2

Brake, softStart: early return

c771b28

Brake: use const rampTo value

a30d4f7

ronso0 mentioned this pull request Mar 29, 2022

Brake: fix infinite run out #4705

Closed

ronso0 force-pushed the spinback-fix branch from 7148301 to 2818272 Compare March 30, 2022 10:35

Scratching: handle spinback independently in brake() & scratchProcess()

e0681a5

* allow spinback when deck is stopped * use -kBrakeRampToRate for spinback to avoid long, inaudible run out * don't allow brake to interrupt spinback * add stopScratchTimer() to remove redundant code

ronso0 force-pushed the spinback-fix branch 2 times, most recently from 984b893 to 011a747 Compare March 30, 2022 21:58

daschuer reviewed Mar 30, 2022

View reviewed changes

src/controllers/controllerengine.cpp Outdated Show resolved Hide resolved

src/controllers/controllerengine.cpp Outdated Show resolved Hide resolved

src/controllers/controllerengine.cpp Outdated Show resolved Hide resolved

ronso0 added 3 commits March 31, 2022 00:35

ControllerEngine: add stopDeck()

7b76d1c

ControllerEngine: stop scratching if no track is loaded

02fba3e

ControllerEngine: more const

ab419ac

ronso0 force-pushed the spinback-fix branch from 011a747 to ab419ac Compare March 30, 2022 22:36

ronso0 added controller mappings engine labels Mar 30, 2022

ronso0 marked this pull request as ready for review April 5, 2022 22:40

daschuer requested changes Apr 6, 2022

View reviewed changes

Scratching: use #if SCRATCH_DEBUG_OUTPUT

03129dd

ronso0 force-pushed the spinback-fix branch from 8218372 to 03129dd Compare April 6, 2022 08:04

daschuer approved these changes Apr 6, 2022

View reviewed changes

daschuer merged commit 629640f into mixxxdj:2.3 Apr 6, 2022

ronso0 deleted the spinback-fix branch April 6, 2022 10:15

ronso0 mentioned this pull request Apr 7, 2022

Merge remote-tracking branch 'upstream/2.3' into main #4716

Merged

ronso0 mentioned this pull request May 18, 2022

Scratch on first wheel touch #4761

Merged

mixxxbot mentioned this pull request Aug 23, 2022

No scratching on touching jog wheel for the first time #9489

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spinback fix #4708

Spinback fix #4708

ronso0 commented Mar 29, 2022 •

edited

Loading

ronso0 commented Mar 29, 2022

ronso0 commented Mar 30, 2022 •

edited

Loading

daschuer left a comment

ronso0 commented Mar 30, 2022 •

edited

Loading

ronso0 commented Mar 30, 2022

daschuer commented Apr 3, 2022

ronso0 commented Apr 3, 2022 •

edited

Loading

ronso0 commented Apr 3, 2022

daschuer commented Apr 4, 2022

daschuer commented Apr 4, 2022

daschuer commented Apr 4, 2022

ronso0 commented Apr 5, 2022

daschuer Apr 6, 2022

ronso0 Apr 6, 2022

ronso0 Apr 6, 2022

daschuer left a comment

Spinback fix #4708

Spinback fix #4708

Conversation

ronso0 commented Mar 29, 2022 • edited Loading

ronso0 commented Mar 29, 2022

ronso0 commented Mar 30, 2022 • edited Loading

daschuer left a comment

Choose a reason for hiding this comment

ronso0 commented Mar 30, 2022 • edited Loading

ronso0 commented Mar 30, 2022

daschuer commented Apr 3, 2022

ronso0 commented Apr 3, 2022 • edited Loading

ronso0 commented Apr 3, 2022

daschuer commented Apr 4, 2022

daschuer commented Apr 4, 2022

daschuer commented Apr 4, 2022

ronso0 commented Apr 5, 2022

daschuer Apr 6, 2022

Choose a reason for hiding this comment

ronso0 Apr 6, 2022

Choose a reason for hiding this comment

ronso0 Apr 6, 2022

Choose a reason for hiding this comment

daschuer left a comment

Choose a reason for hiding this comment

ronso0 commented Mar 29, 2022 •

edited

Loading

ronso0 commented Mar 30, 2022 •

edited

Loading

ronso0 commented Mar 30, 2022 •

edited

Loading

ronso0 commented Apr 3, 2022 •

edited

Loading