Library: keep hidden tracks in history

[ronso0]

Remove hidden tracks from playlists but keep them in the history.

https://mixxx.zulipchat.com/#narrow/stream/109171-development/topic/Hidden.20tracks.20in.20playlists.20.2F.20crates.20.2Fhistory

Interestingly the counterpart to not remove hidden tracks when setting the History table model is already in place:

mixxx/src/library/setlogfeature.cpp

Lines 22 to 33 in 5b6e2e0

	SetlogFeature::SetlogFeature(
	Library* pLibrary,
	UserSettingsPointer pConfig)
	: BasePlaylistFeature(
	pLibrary,
	pConfig,
	new PlaylistTableModel(
	nullptr,
	pLibrary->trackCollections(),
	"mixxx.db.model.setlog",
	/*show-all-tracks*/ true),
	QStringLiteral("SETLOGHOME")),

mixxx/src/library/playlisttablemodel.cpp

Lines 113 to 128 in 5b6e2e0

	void PlaylistTableModel::setTableModel(int playlistId) {
	//qDebug() << "PlaylistTableModel::setTableModel" << playlistId;
	if (m_iPlaylistId == playlistId) {
	qDebug() << "Already focused on playlist " << playlistId;
	return;
	}
	m_iPlaylistId = playlistId;
	if (!m_showAll) {
	// From Mixxx 2.1 we drop tracks that have been explicitly deleted
	// in the library (mixxx_deleted = 0) from playlists.
	// These invisible tracks, consuming a playlist position number where
	// a source user of confusion in the past.
	m_pTrackCollectionManager->internalCollection()->getPlaylistDAO().removeHiddenTracks(m_iPlaylistId);
	}

[uklotzde]

typo

[uklotzde]

The function is called removeTracksFromPlaylists() without any exceptions. Now it contains some special logic in the implementation that is not mentioned anywhere. Functions should do what they are promising.

[ronso0]

Well, if it was removeTracksFromAllPlaylists() I'd fully agree.
What do you propose?
We could simply name it removeTracksFromPlaylistsExceptHistory() since we agreed to keep all tracks in history playlists, no matter if tracks are purged or hidden.

[ronso0]

ping @uklotzde

[uklotzde]

Hijacking playlists for storing play logs was probably not the optimal decision. Now we have to cope with that.

LGTM