-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No testdata copy and circular symlink fix #4728
Conversation
…ata to the build directory.
a9ba9da
to
9e591ac
Compare
I tried this PR locally on Win7 VS2019 and it works flawless. But I got warnings at compile time:
|
.. to make msvc happy. The funktion is not used.
Please retry, the warning should be gone. |
I confirm, the warning is gone! |
I'm going to ng through this commit by commit but it'll tkae some time since I'm nit familiar with the tests. |
44a3e2f
to
17a0cde
Compare
17a0cde
to
3881228
Compare
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type-safe return value improved the code considerably.
Please fix the remaining redundancy. My proposal was just a first idea.
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for simplifying the build and code! LGTM
This PR removes the mixxx-testdata target that copies/symlinks the test data into the build directory.
Instead it makes use of the existing function that is looking up the source tree path form CMakeCache.
This replaces the hard coded paths in the test classes.
This also fixes a circular symlink that happens when changing from 2.3 to main reported here:
https://mixxx.zulipchat.com/#narrow/stream/247620-development-help/topic/Failing.20controller.20test