Made error dialog with "Show Details" so wide, that there are no unnecessary line breaks.

[JoergAtGithub]

Without this PR a ErrorDialog with ShowDetails looked like this (many uneccessary linebreaks and a scrollbar):

Now it looks like this:

Because it's not possible to react on the Show Details button (the event is not public) of QMessageBox, it is neccessary to position the dialog considering the expanded size. Therefore Error Dialogs with details, are openend off center:

[daschuer]

Thank you for taking care.
I have found a typo.

I consider the automatic size changing, that makes the buttons move, a usability issue.
Did you consider to just resize the whole message box to avoid this?

[ronso0]

I appreciate this is finally taken care of, thanks!
Though I'd like to haggle over the size: 1000px is huuuge, this will definitely create issues on R'Pi setups.
Would 800px be sufficient to at least make the most [controller mapping] file paths fit?

[JoergAtGithub]

I could easily limit it to the real screen width.
But for the given font size and the length of the messages, it needs so much pixels.

[ronso0]

I could easily limit it to the real screen width.

👍

[Swiftb0y]

Wouldn't the better solution be to make the textbox which contains the error not break lines but instead horizontally scrollable?

[ronso0]

Wouldn't the better solution be to make the textbox which contains the error not break lines but instead horizontally scrollable?

Good idea, though I find horizontal scrolling cumbersome.
What about a combination of

• expanding the details box in width and height so that expectable file paths fit in (we can estimate the max length of configDir/controllers/Some-Controller-Mapping-file)
• adjust the error message to break after the file path so that the actual error is on a separate line

?

[JoergAtGithub]

I fixed the typo and limited the dialog size in expanded mode to the screen size, to support also devices with tiny low resolution screend like Raspberry Pi.

The objective of this PR is to make the message easier readable. Horizontal scrollbars would do the opposite, because than the interesting part of the message on th right would be invisible by default and would always require scrolling.

Reformatting or analyzing the message text is out of scope of this PR. Feel free to start a follow up PR.

Than there was the remark, if it wouldn't be nicer to show also the collapsed dialog in full width,to prevent the off center dialog. IMHO this is a matter of taste, I think the current solution is the nicer one, because all collapsed dialogs (with or without details) lookinitially the same - just teh position is different.
But I could easily change this, if the majority opinion is, that the collapsed dialog should have also full width.

[daschuer]

LGTM, Thank you.

[daschuer]

@ronso0 Do you want to have a final look?

[ronso0]

For me this crashes after getScreen returns nullptr (dunno why)

[ronso0]

Works good, also with Qt5.12. Thank you!

[ronso0]

LGTM, thank you for taking care of this!

I'll continue with the line-breaks PR.

[ronso0]

somehow I assumed this would be a UX improvement for 2.3.3 but I didn't check.

Does anyone else consider this worth backporting? Is it possible without too much hazzle?
(I would do the work if there's an agreement)

Edit
won't hapen soonish, if at all.
There's more important (and more fun) stuff on the table..

[JoergAtGithub]

From my side backporting is Ok!